Metafor

ULiege - Aerospace & Mechanical Engineering

User Tools

Site Tools


commit:2019:09_25

Commit 2019-09-25

Description

fix getNumberOfTherNod() in tm2 boundaries:

In the previous commit I had found an inconsistency in some Tm2 thermal boundary elements where getNumberOfTherNod() either returned the number of pure thermal (i.e. non-mechanical) nodes or the total number of thermal nodes (which in this case was the same as the total number of nodes). I had solved it by making every element return the number of pure thermal node. After discussion with Luc it might be better to return the total number of thermal nodes so I fixed the problem the other way around and getNumberOfTherNod() now returns the total number of thermal nodes. I also made sure that the loops over thermal nodes is done using getNumberOfTherNod() and not getNumberOfNodes() although this does not change the results since they are equal in tm2 elements.

Rewrite battery tests:

I rewrote some of the battery tests to avoid copy paste.

Added [a] / deleted [d] / modified [m] / renamed [m] files

Code:

[m] mtElements/boundaries/Tm2Convection2DElement.cpp
[m] mtElements/boundaries/Tm2Convection3DElement.cpp
[m] mtElements/boundaries/Tm2ConvectionElement.inl
[m] mtElements/boundaries/Tm2Flux2DElement.cpp
[m] mtElements/boundaries/Tm2Flux3DElement.cpp
[m] mtElements/boundaries/Tm2FluxElement.inl
[m] mtElements/boundaries/Tm2Rayonnement2DElement.cpp
[m] mtElements/boundaries/Tm2Rayonnement3DElement.cpp
[m] mtElements/boundaries/Tm2RayonnementElement.inl
[m] mtElements/boundaries/Tm2VolFlux2DElement.cpp
[m] mtElements/boundaries/Tm2VolFlux3DElement.cpp

Tests:

[m] apps/monosThermoMeca/convection3dLobattoBc.py
[m] apps/monosThermoMeca/convection3dLobattoFull.py
[m] apps/monosThermoMeca/convection3dLobattoVol.py
[m] apps/monosThermoMeca/flux3dLobattoBc.py
[m] apps/monosThermoMeca/flux3dLobattoFull.py
[m] apps/monosThermoMeca/flux3dLobattoVol.py

Cédric Laruelle 2019/09/25

commit/2019/09_25.txt · Last modified: 2019/09/25 16:01 by laruelle